Skip to content

Medcat conversion model name hotfix #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

Medcat conversion model name hotfix #122

merged 2 commits into from
Sep 1, 2025

Conversation

@mart-r
Copy link
Collaborator

@mart-r mart-r commented Aug 29, 2025 •
edited
Loading

This fixes 2 small issues with converted model names:

  • If it's a .zip, the previous implementation would leave teh .zip in the middle of the new name
    • That's because the save mechanism adds the hash and extension (unless otherwise specified)
  • If it's a folder, the converter would fail
    • Because the old_model_name attribute wasn't set

EDIT: This is an extension of #118

@mart-r mart-r changed the title Medcat conversion mode name hotfix Medcat conversion model name hotfix Sep 1, 2025
tomolopolis
tomolopolis approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 880f52b into main Sep 1, 2025
20 checks passed
@mart-r mart-r deleted the medcat-conversion-mode-name-hotfix branch September 1, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomolopolis tomolopolis tomolopolis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mart-r @tomolopolis