-
Notifications
You must be signed in to change notification settings - Fork 4
Bug(medcat): CU-869ag0tqj Fix regex tokenizer dashes #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
…egex-based tokenizer
6aabc68 to
e037bbd
Compare
alhendrickson
approved these changes
Sep 19, 2025
Collaborator
alhendrickson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, now it's much simpler with your latest commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex based tokenizer would treat all words that had some punctuation in them as skip words and would skip them.
And because of that, these tokens would be ignored since the tagger would tag them as skip words because they contained punctuation.
This PR fixes that by separating the punctuation in the regex based tokenizer example.
This should fix #128.
EDIT:
To be a bit more explicit regarding the regex tokenizer:
know-howintoknowand-howknow-howintoknow,-, andhow