Skip to content

CU-8699pqzp5 Legacy conversion #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

CU-8699pqzp5 Legacy conversion #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2533605
CU-8699pqzp5: Fix config conversion when old config does not have a v…
mart-r Jul 7, 2025
878360c
CU-8699pqzp5: Convert en_core_sci_lg to en_core_web_md at model conve…
mart-r Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion medcat-v2/medcat/utils/legacy/convert_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def get_val_and_parent_model(old_data: Optional[dict],
logger.warning(
"Optional path '%s' not found in old config. Ignoring",
path)
val = None
break
val = val[cname]
return val, target_model
Expand Down Expand Up @@ -166,7 +167,8 @@ def get_config_from_nested_dict(old_data: dict) -> Config:
# but we now default to regex
cnf.general.nlp.provider = 'spacy'
cnf = _make_changes(cnf, old_data)
if cnf.general.nlp.modelname in ('spacy_model', 'en_core_sci_md'):
if cnf.general.nlp.modelname in ('spacy_model', 'en_core_sci_md',
'en_core_sci_lg'):
logger.info("Fixing spacy model. "
"Moving from '%s' to 'en_core_web_md'!",
cnf.general.nlp.modelname)
Expand Down