Skip to content

Conversation

@alhendrickson
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mart-r mart-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's in the v1 folder, do we want to perhaps remove teh -v1 suffix of the folders? Seems to be duplicating the information.

There's a bunch of links in the v1 folder that are either still pointing at old stuff (e.g v1/medcat-v1-tutorials/README.md has a bunch of links; the tutorial notebooks refer to raw files within the old /separate repo; the v1 docs and readme refer to old/separate tutorials repo; the v1/medcat-v1/docs/main.md refers to a non-existing https://github.com/CogStack/cogstack-nlp/tree/main/medcat-trainer/; )
But I'm not sure if it's worth trying to fix all that...

@alhendrickson
Copy link
Collaborator Author

If it's in the v1 folder, do we want to perhaps remove teh -v1 suffix of the folders? Seems to be duplicating the information.

There's a bunch of links in the v1 folder that are either still pointing at old stuff (e.g v1/medcat-v1-tutorials/README.md has a bunch of links; the tutorial notebooks refer to raw files within the old /separate repo; the v1 docs and readme refer to old/separate tutorials repo; the v1/medcat-v1/docs/main.md refers to a non-existing https://github.com/CogStack/cogstack-nlp/tree/main/medcat-trainer/; ) But I'm not sure if it's worth trying to fix all that...

I've removed the suffix, makes sense to me

& Yeah the links are all to be changed... I've had it as a todo for ages but I've been trying to logically justify not doing it but really I just need to get it done. As at least it's been mentioned now so it's likely to be worth while - I'll fix up these links on the old projects next week.

@alhendrickson alhendrickson merged commit 8f4fbda into main Aug 13, 2025
24 checks passed
@alhendrickson alhendrickson deleted the chore/move-v1-medcat-into-subfolder branch August 13, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants