Duplicate constructors when using 'using' #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CppAst/CppModelBuilder.cs
Outdated
| cppClass.Constructors.Add(cppFunction); | ||
| } | ||
| } | ||
| else |
There was a problem hiding this comment.
[nitpick] You can merge the else and the if into an else if.
balazssomogyi
approved these changes
Dec 6, 2023
For some reason libclang adds the same constructors multiple times when doing the visit on a 'using' expression. This change makes sure that only "unique" functions / constructors are being added.
harsszegi
force-pushed
the
bugfix/visit_unique_constructors
branch
from
eb2ede4 to
414a4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason libclang adds the same constructors multiple times when doing the visit on a 'using' expression. This change makes sure that only "unique" functions / constructors are being added.