'using' is not recognized #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsszegi
requested review from
balazssomogyi,
cnx-tcsikos,
ninloot,
sirthomas96,
stevew-cgnx and
yjiao-cgnx
src/CppAst/CppModelBuilder.cs
Outdated
|
|
||
| var functionName = GetCursorSpelling(cursor); | ||
| // This (not using 'cursor', but 'destinationCursor') is only used when we pulling in constructors from Foo, into Bar | ||
| // We are renming effectively the pulled in 'Foo' constructor into 'Bar' |
There was a problem hiding this comment.
renming -> renaming? (If yes, what do you mean by renaming the ctor into another class?)
Author
There was a problem hiding this comment.
Yeah, exactly, with "using" if you have Bar : public Foo, when "using" is parsed in "Bar", you'll get Foo's constructors, e.g. "Foo::Foo", so when we add those to "Bar", we need to rename them to "Bar::Bar"
src/CppAst/CppModelBuilder.cs
Outdated
| // it only works with constructors | ||
| if (childCursor.Kind == CXCursorKind.CXCursor_OverloadedDeclRef) | ||
| { | ||
| // We simply |
There was a problem hiding this comment.
It seems that the second half of the comment is missing.
balazssomogyi
approved these changes
Nov 28, 2023
In case the "using" expression is used within a class declaration, the functions pulled by "using" are not recognized. This PR adds this, but only for constructors.
harsszegi
force-pushed
the
feature/fix_using
branch
from
0e31228 to
1ef651d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the "using" expression is used within a class declaration, the functions pulled by "using" are not recognized. This PR adds this, but only for constructors.