This repository was archived by the owner on Feb 25, 2023. It is now read-only.
(feat) fixes #2557: makes ETH routes non Balancer specific #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/CoinAlpha/hummingbot/issues/2557
To make these functions non Balancer specific, this PR adds a
spenderAddressparameter to/eth/approveand/eth/allowances, so the Balancer connector in the client needs to be changed to pass in the Balancer exchangeProxy address (mainnet:0x3E66B66Fd1d0b02fDa6C811Da9E0547970DB2f21).I think the Balancer exchangeProxy address should be a global parameter that we set to the current mainnet address. If users want to test on Kovan, they are responsible for changing it.