This repository was archived by the owner on Feb 25, 2023. It is now read-only.
Refactor / refactor uniswap price routes to use execution price #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vic-en
changed the title
fengtality
approved these changes
Nov 24, 2020
Contributor
fengtality
left a comment
fengtality
left a comment
There was a problem hiding this comment.
LGTM - In my commit, I made the minor fixes described in the comments and also changed Uniswap GAS_LIMIT to 150k since gas used in my test transactions were approximately 110k-115k. In the Uniswap connector in the client, please ensure that the profitability calculation uses the same 150k gas limit assumption.
fengtality
approved these changes
Nov 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor price routes to use execution price from Uniswap's trade class.