Feat / update eth routes to handle token decimals properlly #18
Conversation
vic-en
requested review from
fengtality and
gyozajiro
and removed request for
gyozajiro
| let tokenAddressList | ||
| if (paramData.tokenAddressList) { | ||
| tokenAddressList = paramData.tokenAddressList.split(separator) | ||
| tokenAddressList = JSON.parse(paramData.tokenAddressList) |
There was a problem hiding this comment.
This will change the tokenAddressList from comma separated value to JSON string. HB client update will be needed for this change.
There was a problem hiding this comment.
yeah, that is already handled in the PR 2690 mentioned above.
There was a problem hiding this comment.
This change makes it harder to test with Postman, since the tokenAddressList param in eth/balances and eth/allowances endpoints is a more complex object. Instead of passing in a dict, can we pass in two arrays: tokenAddressList and tokenDecimalList?
| let tokenAddressList | ||
| if (paramData.tokenAddressList) { | ||
| tokenAddressList = paramData.tokenAddressList.split(separator) | ||
| tokenAddressList = JSON.parse(paramData.tokenAddressList) |
There was a problem hiding this comment.
This change makes it harder to test with Postman, since the tokenAddressList param in eth/balances and eth/allowances endpoints is a more complex object. Instead of passing in a dict, can we pass in two arrays: tokenAddressList and tokenDecimalList?
Linked to PR https://github.com/CoinAlpha/hummingbot/pull/2690