Skip to content

Conversation

@KalanaRatnayake
Copy link
Collaborator

@KalanaRatnayake KalanaRatnayake commented Sep 18, 2024

Major Changes

  1. Removed ActionClientManager and moved its functionality to MultiActionRunner itself.
  2. Moved the ActionClientBundle into a folder 'include/struct' and into its own .hpp file
  3. Added action_runnerv2.hpp as an improvement over action_runner.hpp.
  4. Runners can now be triggered with trigger_action which is non-blocking and trigger_action_wait. Use former where only action triggering matters and latter where result message of the action matters.
  5. trigger_action returns "True" upon successful action triggering and trigger_action_wait returns "True" upon successful completion.

Major Changes

  • Complete
  • Compiles
  • Tested

Next Steps

  1. Need to select between action_runnerv2.hpp and action_runner.hpp
  2. Need to improve the runnercacher and api to capture the runner status from trigger() fucntion

…ctionRunner. Added improved trigger_action with blocking and non-blocking functionality
@KalanaRatnayake KalanaRatnayake added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2024
@KalanaRatnayake KalanaRatnayake requested review from BuddhiGamage and mik-p and removed request for mik-p September 18, 2024 13:21
@mik-p mik-p merged commit 1fed1f6 into develop Sep 18, 2024
@KalanaRatnayake KalanaRatnayake deleted the action-runner branch October 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants