Add scroll reach bottom api for lazy loading usage #1824
Conversation
…roll reached to bottom
| .rdg-grid { | ||
| // min-height is here to show the horizontal scrollbar when there are no rows | ||
| min-height: 1px; | ||
| margin-bottom: 8px; |
There was a problem hiding this comment.
Add small space between the bottom row and the bottom border, as the editable small square will increase the height size a little bit, so it's better to leave the margin in advance to avoid some randomly bug that a cell cannot be edited.
| }, [rowHeight, scrollToRowIndex]); | ||
|
|
||
| useEffect(() => { | ||
| if (scrollTop + clientHeight - rowHeight * rowsCount === 8) { |
There was a problem hiding this comment.
8 is corresponding to this line.
https://github.com/adazzle/react-data-grid/pull/1824/files#diff-ee619d375026eab3db5bbae675917325R32
| } | ||
|
|
||
| export interface ScrollOption extends ScrollPosition { | ||
| reachedBottom?: boolean; |
There was a problem hiding this comment.
We might want to revisit the API name, but I believe this should be a reasonable API.
There was a problem hiding this comment.
Or should I add a stand alone API like onReachedBottom to be explicitly?
|
Why not just surface the scroll event object, then users can just check for themselves: event.target.clientHeight + event.target.scrollTop === event.target.scrollHeight |
|
blocked by #1852 |
|
Superseded by this #1854 |
2 participants
Uh oh!
There was an error while loading. Please reload this page.