Remove onCheckCellIsEditable prop #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
force-pushed
the
use-column-editable-instead
branch
from
bf2e479 to
f7112c6
Compare
nstepien
commented
Apr 22, 2020
src/utils/columnUtils.ts
Outdated
| // Logic extented to allow for functions to be passed down in column.editable | ||
| // this allows us to decide whether we can be editing from a cell level | ||
| export function canEdit<R, SR>(column: Column<R, SR>, row: R): boolean { | ||
| if (typeof column.editable === 'function') { |
There was a problem hiding this comment.
I wonder if we should move canEdit to selectedCellUtils.ts. It is only used once
amanmahajan7
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also made it so
editable: falsedisables the editor, whether we have an editor or not.