Promote editor2 #2149
Merged
Promote editor2 #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstepien
commented
Oct 28, 2020
| import { useCallback } from 'react'; | ||
|
|
||
| export function useCombinedRefs<T>(...refs: readonly React.Ref<T>[]) { | ||
| return useMemo( |
There was a problem hiding this comment.
https://reactjs.org/docs/hooks-reference.html#usememo
You may rely on useMemo as a performance optimization, not as a semantic guarantee. In the future, React may choose to “forget” some previously memoized values and recalculate them on next render, e.g. to free memory for offscreen components. Write your code so that it still works without
useMemo— and then add it to optimize performance.
Looks like useCallback is safer than useMemo for this hook 🤔
| import Cell from './Cell'; | ||
| import helpers, { Row } from './test/GridPropHelpers'; | ||
| import { SimpleCellFormatter } from './formatters'; | ||
| import { ValueFormatter } from './formatters'; |
| editorProps: SharedEditorProps<TRow>; | ||
| } | ||
|
|
||
| export interface SelectedCellProps extends SelectedCellPropsBase { |
There was a problem hiding this comment.
At some point we should revisit the exported types. We may not want to export everything
amanmahajan7
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.