Fix scrolling on a merged cell #2368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2021 07:09
nstepien
reviewed
Apr 22, 2021
gernotkogler
pushed a commit
to Garaio-REM/react-data-grid
that referenced
this pull request
May 13, 2021
* Fix scrolling on a merged cell * Tweak row check * Idx can also be out of bounds * Use right position instead of left * Move validateCellPosition to utils * test scroll position * Test cell position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colSpanwas introduced in #2356. We need to ensure the merged cell width is used while scrolling to a cell.