Skip to content

Conversation

amanmahajan7
Copy link
Collaborator

colSpan was introduced in #2356. We need to ensure the merged cell width is used while scrolling to a cell.

@amanmahajan7 amanmahajan7 requested a review from nstepien April 21, 2021 21:17
@amanmahajan7 amanmahajan7 self-assigned this Apr 21, 2021
Copy link
Collaborator

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests? 🤔

Copy link
Collaborator

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥛

@amanmahajan7 amanmahajan7 merged commit 62e8a87 into canary Apr 22, 2021
@amanmahajan7 amanmahajan7 deleted the am-fix-colspan-cell-scrolling branch April 22, 2021 15:01
gernotkogler pushed a commit to Garaio-REM/react-data-grid that referenced this pull request May 13, 2021
* Fix scrolling on a merged cell

* Tweak row check

* Idx can also be out of bounds

* Use right position instead of left

* Move validateCellPosition to utils

* test scroll position

* Test cell position
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants