Linaria: disable autoprefixing #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
previously approved these changes
Apr 22, 2021
…g in babel config
nstepien
commented
Apr 22, 2021
| "useBuiltIns": "entry", | ||
| "include": [ | ||
| "@babel/proposal-nullish-coalescing-operator", | ||
| "@babel/proposal-optional-chaining" |
There was a problem hiding this comment.
These are included anyway as long as we support "maintained node versions"
https://github.com/adazzle/react-data-grid/blob/canary/browserslist#L5
amanmahajan7
approved these changes
Apr 22, 2021
gernotkogler
pushed a commit
to Garaio-REM/react-data-grid
that referenced
this pull request
May 13, 2021
* Linaria: disable autoprefixing * rm proposal-nullish-coalescing-operator and proposal-optional-chaining in babel config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callstack/linaria#57 (comment)
Linaria/Stylis add a LOT of prefixed css properties, when we don't need any of them, so I disabled them. I don't think we need any prefixes anymore nowadays. And if we do I'd rather we manage it ourselves. Prefixes is a thing of the past and browsers don't add new ones anymore.
The css properties in the devtools will be less polluted now.
We don't even have any prefixes in our codebase anymore afaict.
Build output example:
