-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Feature: RTL #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature: RTL #2803
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
f608867
Use css logic properties
7ddcbed
Use :dir pseudo class to set row borders
94aff1a
Fix virtualization
fa3952c
Use block/inline size instead of height/ width
3cba825
use start/end with text align
bf879b4
Adjust context menu styles
c2e5509
Fix expand icon styles
860626e
Use padding-block/inline
41fa638
Fix virtualization and column resize
7bdcfbd
Merge branch 'main' into am-rtl
amanmahajan7 250d00b
Add Rtl example
fbf07db
Revert rename
81ff94b
scrollTop is positive
6b7a8a0
Fix margin
fc203bc
Rename css variables for clarity
30bc31e
Update src/DataGrid.tsx
amanmahajan7 bbc8f11
Update src/DataGrid.tsx
amanmahajan7 37d6141
Update src/DataGrid.tsx
amanmahajan7 5e4e846
Update website/Nav.tsx
amanmahajan7 833b6b6
Add missing content menu style, minor cleanup
d40f551
Add global Right to left checkbox
d71d651
Add key to create root component when direction is changed
920bae4
Update readme
692f669
Fix styling
79eb126
Fix frozen cell style
833f188
Fix box shadow
25dec9e
Add dir prop
1041e6f
Add direction prop
f11e3dc
Update examples to use the direction prop
a69892a
Update README.md
amanmahajan7 34a13eb
Remove key
61e8619
Fix resizing
168cc78
Add key to recreate grid when direction is changed
a0dba05
Fix direction in portals
9c5e0a8
Fix arrow direction in rtl
7704927
Switch left/right keys for groups
c3ef41f
Merge branch 'main' into am-rtl
d173762
Update README.md
amanmahajan7 dffa921
Merge branch 'main' into am-rtl
amanmahajan7 f6e23b1
Use the direction prop
0d62d4e
Add direction prop
0001583
More details on RTL
132b34a
Update type
b4dc8e8
Test direction prop
9a11792
Fix tests
06270e3
Update README.md
amanmahajan7 2feb4fe
Move the direction file outside
1ab2433
Remove dir and use a new sign variable
3649f3c
Add a comment
d188c85
Move rtl tests to keyboardNavigation.test
f391841
Revert "Move rtl tests to keyboardNavigation.test"
07c5263
Only move the navigation tests to keyboardNavigation.test file
4929122
Remove confusing comment
5600176
Key is not required
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is negative in RTL