External copy paste handlers #2981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaoncode
approved these changes
Aug 14, 2022
jotaoncode
reviewed
Aug 14, 2022
| onPasteCallback?: boolean; | ||
| onCopyCallback?: boolean; | ||
| externalCopy?: boolean; | ||
| externalPaste?: boolean; |
There was a problem hiding this comment.
I would try to keep the "on" convention they have in the previous callers, just to keep aligned with their code style.
Code looks good and thanks for this improvement, I am looking forward to this change too.
|
This is a feature Which I need |
|
Hi @DVGY do you still need this feature or did you find another way? Thanks!! |
Still need this feature |
This was referenced Feb 24, 2024
Closed
Collaborator
|
Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two callback props for the copy and paste events. The new props allow developers to write their own logic for the copy and paste events. Thereby, allowing the devs to respond to the events as they see fit, by having all of the logic outside of react-data-grid.
The primary limitations of the internal copy/paste logic provided by react-data-grid, is the inability to copy/paste items from external sources by writing to the clipboard. As well as the limitation of only being able to copy one cell at a time. By letting developers write there own logic to these events, these use cases can be addressed by enabling the dev to write their own logic.
Possible use cases for these two props: