Skip to content

Linaria 6 #3407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 14, 2023
Merged

Linaria 6 #3407

merged 7 commits into from
Dec 14, 2023

Conversation

@amanmahajan7
Copy link
Collaborator

@amanmahajan7 amanmahajan7 commented Dec 14, 2023 •
edited
Loading

@amanmahajan7 amanmahajan7 self-assigned this Dec 14, 2023
@amanmahajan7
Revert "-1"
17a7d11 
This reverts commit e68977a.
@amanmahajan7
Revert "Update imports"
64490e2 
This reverts commit 5848bfe.
nstepien
nstepien reviewed Dec 14, 2023
View reviewed changes
@amanmahajan7
Copy link
Collaborator Author

amanmahajan7 commented Dec 14, 2023

styles.css is the same but bundle.js is completely different. Were we packaging it incorrectly before?

image

@nstepien
Copy link
Collaborator

nstepien commented Dec 14, 2023

There shouldn't be any remaining css`` in the output 🤔

@amanmahajan7
Copy link
Collaborator Author

amanmahajan7 commented Dec 14, 2023

May be I incorrectly generated the bundle in the main branch
image

@amanmahajan7
Copy link
Collaborator Author

amanmahajan7 commented Dec 14, 2023

Anyway looks like the output is the same

@amanmahajan7 amanmahajan7 marked this pull request as ready for review December 14, 2023 19:45
amanmahajan7
amanmahajan7 commented Dec 14, 2023
View reviewed changes
package.json
"@ianvs/prettier-plugin-sort-imports": "^4.0.2",
"@linaria/rollup": "^5.0.3",
"@linaria/vite": "^5.0.3",
"@linaria/core": "^6.0.0",
Copy link
Collaborator Author

@amanmahajan7 amanmahajan7 Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be installed now

@amanmahajan7 amanmahajan7 merged commit aeb1cb2 into main Dec 14, 2023
@amanmahajan7 amanmahajan7 deleted the am-@wyw-in-js branch December 14, 2023 21:22
@oliviertassinari oliviertassinari mentioned this pull request Feb 26, 2024
Open
adityatoshniwal pushed a commit to pgadmin-org/react-data-grid that referenced this pull request Jul 31, 2024
@amanmahajan7 @adityatoshniwal
Linaria 6 (Comcast#3407)
3de7b1d 
* Install new @wyw-in-js packages

* Update imports

* -1

* Revert "-1"

This reverts commit e68977a.

* Revert "Update imports"

This reverts commit 5848bfe.

* Use the new packages

* Rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstepien nstepien nstepien approved these changes

Assignees

@amanmahajan7 amanmahajan7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amanmahajan7 @nstepien