Fix cell stealing focus on click #3790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3790 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 46 46
Lines 3516 3518 +2
Branches 766 766
=======================================
+ Hits 3474 3476 +2
Misses 42 42
🚀 New features to boost your workflow:
|
amanmahajan7
commented
May 21, 2025
| }); | ||
|
|
||
| selectCell(nextSelectedCellPosition); | ||
| selectCell(nextSelectedCellPosition, { shouldFocusCell: true }); |
There was a problem hiding this comment.
We only need to set shouldFocusCell flag on cell navigation using keyboard.
| setIsChildFocused(false); | ||
| } | ||
|
|
||
| function onFocus(event: React.FocusEvent<HTMLDivElement>) { |
There was a problem hiding this comment.
When a cell is clicked it is automatically focused as the cell has a tabIndex: -1. We can focus the child here
nstepien
previously approved these changes
May 21, 2025
Co-authored-by: Nicolas Stepien <567105+nstepien@users.noreply.github.com>
amanmahajan7
commented
May 21, 2025
nstepien
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #3774