Remove clsx dependency
#3883
Merged
Remove clsx dependency
#3883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3883 +/- ##
=======================================
Coverage 97.60% 97.61%
=======================================
Files 42 42
Lines 1253 1257 +4
Branches 348 348
=======================================
+ Hits 1223 1227 +4
Misses 30 30
🚀 New features to boost your workflow:
|
amanmahajan7
commented
Oct 7, 2025
| "@vitest/eslint-plugin": "^1.3.4", | ||
| "@wyw-in-js/rollup": "^0.7.0", | ||
| "@wyw-in-js/vite": "^0.7.0", | ||
| "clsx": "^2.1.1", |
Collaborator
Author
There was a problem hiding this comment.
Kept this for website
nstepien
approved these changes
Oct 7, 2025
| } | ||
| } | ||
|
|
||
| return classname.trimStart(); |
Collaborator
There was a problem hiding this comment.
also valid
Suggested change
| return classname.trimStart(); | |
| return classname.slice(1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clsxis quite a small utility and we do not need all the features so I think we can write our own simplified version.