[API Node] Sort API templates by name #3721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
May 1, 2025
src/stores/workflowTemplatesStore.ts
Outdated
| } from '@/types/workflowTemplateTypes' | ||
| import { normalizeI18nKey } from '@/utils/formatUtil' | ||
|
|
||
| const SHOULD_SORT_CATEGORIES = new Set(['Image API', 'Video API']) |
Contributor
There was a problem hiding this comment.
Can you leave a comment here that explains why only 2 categories are sorted?
Contributor
Author
|
Test failed because screenshot was not generated yet: Should be fixed by #3724 |
huchenlei
approved these changes
May 2, 2025
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort API node templates by specifying a set of template categories that should have their individual templates sorted by name alphabetically. This ensure that, for API node templates, there is no favoritism or bias in how the templates are ordered. For the existing template categories, maintain the current ordering (allow to be re-arranged by changing the index.json).
Resolves Comfy-Org/workflow_templates#45
┆Issue is synchronized with this Notion page by Unito