Orientation option for Segmented #747
Conversation
|
So far I've added an 
|
|
Here's an update. Though this does have a slight change in the horizontal style, namely the selected indicator is centered on the full Before: |
Avid29
force-pushed
the
Segmented/VerticalOrientation
branch
from
24309cb to
4d35ca1
Compare
|
@niels9001 was there a reason the indicator was centered under the content only vs. the entire content? That'll only matter in Icon + Text Horizontal mode. |
|
@Avid29 this works perfect! 
Just slotted right into my VSM with changing the orientation and I was done! 🦙❤️ I'll take a look through the code itself in a bit. |
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Looks pretty clean to me. @niels9001 @Arlodotexe let me know your thoughts.
| var container = ContainerFromIndex(i) as SegmentedItem; | ||
| if (container is null) | ||
| continue; | ||
|
|
||
| container.UpdateOrientation(Orientation); |
There was a problem hiding this comment.
| var container = ContainerFromIndex(i) as SegmentedItem; | |
| if (container is null) | |
| continue; | |
| container.UpdateOrientation(Orientation); | |
| if (ContainerFromIndex(i) is SegmentedItem item) | |
| { | |
| item.UpdateOrientation(Orientation); | |
| } |
Would this be simpler?
There was a problem hiding this comment.
Yeah. I have a tendency to over user guard checks...
| using Windows.Media.Devices; | ||
|
|
There was a problem hiding this comment.
Accidental namespace add?
There was a problem hiding this comment.
Yeah. Visual Studio really just adds whatever as I type and I often forget to even check 🤷
There was a problem hiding this comment.
Yeah, I wonder if it's better in VS 2026, I'll have to see as I use it more. It's definitely been a bigger problem in the last year or so than it was in the past.
| RegisterPropertyChangedCallback(SelectedIndexProperty, OnSelectedIndexChanged); | ||
| RegisterPropertyChangedCallback(OrientationProperty, OnSelectedIndexChanged); |
There was a problem hiding this comment.
Would it make sense to extract the logic in OnSelectedIndexChanged into a SaveInitialIndex method then call it from OnSelectedIndexChanged and OnOrientationChanged?
There was a problem hiding this comment.
Oh, wait a minute. That's supposed to call OnOrientationChanged... Yet it does work. Why is that?
There was a problem hiding this comment.
Oh, I see. Because I moved the callback to the DependencyProperty declaration. This line is entirely unnecessary.
Co-authored-by: Andrew KeepCoding <andrewkeepcoding@gmail.com>
3 participants
Fixes #746
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There is not orientation options for the Segmented control
What is the new behavior?
Add customization options for a vertical Segmented control
PR Checklist
Please check if your PR fulfills the following requirements:
Other information