Unseal RelayCommand and AsyncRelayCommand

[e0ff]

Overview

I'm working on custom command that will let the developer pass a permission string into the constructor and if the user has that permission then command will be enabled if CanExecute returns true and will be disabled when CanExecute returns false or the user doesn't have that permission. I wanted to inherit from RelayCommand and AsyncRelayCommand but am not able to due to them being marked as sealed.

API breakdown

Remove sealed keyword from RelayCommand and AsyncRelayCommand.

Usage example

public class CustomCommand : RelayCommand {
    ...
}

public class AsyncCustomCommand : AsyncRelayCommand {
    ...
}

Breaking change?

No

Alternatives

Re-implement RelayCommand and AsyncRelayCommand functionality for custom commands.

Additional context

No response

Help us help you

No, just wanted to propose this

[Palatis]

i think you can implement your own IRelayCommand?
and for what you're trying to do, maybe the check should be done in the CanExecute callback?

[labsin]

I'm also running into this.

Some other usage example:

• Adding logging around commands
• Injecting feature flags for CanExecute

The issues I run into by using composition:

• IAsyncRelayCommand has a lot of members to implement => can be automated by VS
• WPF expects the sender of PropertyChanged and CanExecuteChanged to be this
  So I have to subscribe to the private relay command event and re-raise the this
  If not done, WPF just does nothing on those events without any warning or error

[Phyyl]

We also hit this limitation. On thing to note: the source generators need to support configurable types for generated properties.

For our use case, [RelayCommand] would need to be configurable with our own custom subclass of RelayCommand. Perhaps through msbuild properties?