Skip to content

Conversation

@yuumasato
Copy link
Member

Description:

  • Remove slash from example faillock audit rule
  • Update scenario for SSGTestSuite

Rationale:

From audit PoV, it doesn't matter if the trailing slash is there or not.
But our check is written so that the slash should no be there.
@yuumasato yuumasato added bugfix Fixes to reported bugs. Test Suite Update in Test Suite. Rule labels Aug 30, 2018
@dahaic
Copy link
Contributor

dahaic commented Aug 30, 2018

@yuumasato when you are touching this, can you rename default.fail.sh scenario to more meaningful empty.fail.sh? Default is bit ambiguous.

@dahaic dahaic self-assigned this Aug 30, 2018
@dahaic dahaic added this to the 0.1.41 milestone Aug 30, 2018
@yuumasato
Copy link
Member Author

@dahaic Sure, done.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@dahaic
Copy link
Contributor

dahaic commented Aug 30, 2018

Thanks @yuumasato . Ack

@dahaic dahaic merged commit 78cb4a4 into ComplianceAsCode:master Aug 30, 2018
@yuumasato yuumasato deleted the audit_login_events_description_trailing_slash branch August 30, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes to reported bugs. Test Suite Update in Test Suite.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants