[cu-30xvvc2, cu-30xvvc7][Pablo Refactor] Adding new function signatures and types

[vimukthi-git]

Description

• Introducing new types and function signatures for Amm trait
• Handling fall out in Pablo
• Handling fall out in Dex-router

[itsbobbyzz]

Task linked: CU-30xvvc7 5.3) 2. Implement Algorithm: Amm::currency_pair → Amm::assets.

[itsbobbyzz]

Task linked: CU-30xvvc2 5.3) 1. Implement Refactoring: CurrencyPair Usage.

[github-actions]

Nix commands for this PR

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/fb242210c02e796a90de3fd36fe1d948bcd42fe8 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/fb242210c02e796a90de3fd36fe1d948bcd42fe8#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/fb242210c02e796a90de3fd36fe1d948bcd42fe8#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/fb242210c02e796a90de3fd36fe1d948bcd42fe8#devnet-xcvm-up" -L

Are you on macOS, or do you not have Nix installed? No worries, you can also run these commands in Docker like this:

(you only need to run the first command once on your machine)

docker volume create nix

docker run --privileged --rm -v nix:/nix  -v /var/run/docker.sock:/var/run/docker.sock -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/composable/fb242210c02e796a90de3fd36fe1d948bcd42fe8#devnet-up -L --option cores 8 --extra-experimental-features nix-command --extra-experimental-features flakes"

Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

[codecov-commenter]

Codecov Report

Base: 21.68% // Head: 21.89% // Increases project coverage by +0.20% 🎉

Coverage data is based on head (f9a0ed8) compared to base (70c52d1).
Patch coverage: 88.11% of modified lines in pull request are covered.

❗ Current head f9a0ed8 differs from pull request most recent head fb24221. Consider uploading reports for the commit fb24221 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
+ Coverage   21.68%   21.89%   +0.20%     
==========================================
  Files         419      420       +1     
  Lines      153620   154086     +466     
==========================================
+ Hits        33316    33730     +414     
- Misses     120304   120356      +52     

Impacted Files	Coverage Δ
code/parachain/runtime/dali/src/lib.rs	4.33% <0.00%> (+0.02%)	⬆️
code/parachain/frame/pablo/src/lib.rs	42.60% <70.31%> (-3.49%)	⬇️
code/parachain/frame/dex-router/src/lib.rs	46.38% <75.38%> (+6.70%)	⬆️
...ame/pablo/src/dual_asset_constant_product_tests.rs	91.75% <83.90%> (-8.25%)	⬇️
code/parachain/frame/composable-traits/src/dex.rs	82.25% <93.75%> (+10.03%)	⬆️
...ode/parachain/frame/dex-router/src/benchmarking.rs	100.00% <100.00%> (ø)
code/parachain/frame/dex-router/src/tests.rs	100.00% <100.00%> (ø)
code/parachain/frame/pablo/src/benchmarking.rs	100.00% <100.00%> (ø)
...parachain/frame/pablo/src/common_test_functions.rs	100.00% <100.00%> (ø)
...ain/frame/pablo/src/dual_asset_constant_product.rs	100.00% <100.00%> (+1.23%)	⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[vimukthi-git]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed