-
Notifications
You must be signed in to change notification settings - Fork 26
Arm updates #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm updates #1186
Conversation
| # Ignore the specific UserWarning about non-interactive FigureCanvasAgg | ||
| warnings.filterwarnings( | ||
| "ignore", r"FigureCanvasAgg is non-interactive, and thus cannot be shown" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just filtered out the additional warning but another option would be to override plt.show to be a no-op
in this context or to save the non-gui plot that is generated instead of attempting to show, then restore the plt.show on exit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good enough, thanks.
| # Ignore the specific UserWarning about non-interactive FigureCanvasAgg | ||
| warnings.filterwarnings( | ||
| "ignore", r"FigureCanvasAgg is non-interactive, and thus cannot be shown" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good enough, thanks.
|
I'm just going to merge this in so we can have just the shifts and Swt patches outstanding. |
After updating my conda installation to the M1 version I came across a couple test failures and warnings:
This PR resolves all the warnings and failed tests for Python 3.8-3.11 on the arm platform (aside from the numpy.distutils deprecation warning related to an external package).