Skip to content

Arm updates #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Arm updates #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acad43f
Resolve matplotlib warning.
j-c-c Oct 1, 2024
b7ca523
Increase FLE test tolerance to 30%
j-c-c Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_FLEbasis2D.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class TestFLEBasis2D(UniversalBasisMixin):
if backend_available("cufinufft"):
test_eps = 1.15
elif platform.system() == "Darwin":
test_eps = 1.20
test_eps = 1.30

# check closeness guarantees for fast vs dense matrix method
def testFastVDense_T(self, basis):
Expand Down
5 changes: 5 additions & 0 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,11 @@ def matplotlib_no_gui():
with warnings.catch_warnings():
warnings.filterwarnings("ignore", r"Matplotlib is currently using agg.*")

# Ignore the specific UserWarning about non-interactive FigureCanvasAgg
warnings.filterwarnings(
"ignore", r"FigureCanvasAgg is non-interactive, and thus cannot be shown"
)
Comment on lines +400 to +403
Copy link
Collaborator Author

@j-c-c j-c-c Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just filtered out the additional warning but another option would be to override plt.show to be a no-op
in this context or to save the non-gui plot that is generated instead of attempting to show, then restore the plt.show on exit.

Copy link
Collaborator

@garrettwrong garrettwrong Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good enough, thanks.


yield

# Explicitly close all figures before making backend changes.
Expand Down
Loading