Long Running Class avg test patches #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1056 +/- ##
===========================================
- Coverage 89.19% 89.16% -0.03%
===========================================
Files 126 126
Lines 11936 11933 -3
===========================================
- Hits 10646 10640 -6
- Misses 1290 1293 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at settling down the class average tests that became increasingly flaky as the image size was reduced (for timing reasons).
This PR does two things. Fixes a diagnostic fixture log message and scales down the compressed bispectrum components by about the same factor I previously scaled the image size.
I have run this patched
Long Running Test Suiteover 15 times in the GHA CI ondecafwith no failures. Hoping this finally resolves it for a while.Had to rebase PR this morning due to #1054 .