Shared Basis Rotate test #1057
Merged
Shared Basis Rotate test #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
force-pushed
the
basis_rot
branch
from
343e68c to
3405b89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1057 +/- ##
===========================================
- Coverage 89.15% 89.07% -0.08%
===========================================
Files 126 126
Lines 11957 11957
===========================================
- Hits 10660 10651 -9
- Misses 1297 1306 +9 ☔ View full report in Codecov by Sentry. |
garrettwrong
force-pushed
the
basis_rot
branch
from
44854c0 to
49fe5f9
Compare
reduces regular ut time
j-c-c
requested changes
Nov 30, 2023
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good. Just the one suggestion.
garrettwrong
force-pushed
the
basis_rot
branch
from
49fe5f9 to
aff1131
Compare
Collaborator
Author
|
Merging. Centralizes and expands unit test coverage to additional 2D basis. Converts some older tests towards pytest fixtures. No new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing two specific (FFB, FLE) basis rotate tests with a simpler (and faster) shared test for all the 2d steerables.
Initially I put them in
test_rotation.py, migrating that towards pytest. Changed mind, preferred,test_rotation.pyto target theRotationclass and put the rotate tests in a new filetest_steerable_bases_2d.py