Importlib unhack

[garrettwrong]

This top level import (which I put in a long time ago for potential convenience) seems to be causing increased memory usage.

I don't think anyone uses the feature. Its also most of what makes the first import of aspire slow.

Tentatively suggesting we remove it. Running some large experiments now to see if improves the resource utilization.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (347c779) 89.08% compared to head (6707f72) 88.76%.

Files	Patch %	Lines
src/aspire/__init__.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1064      +/-   ##
===========================================
- Coverage    89.08%   88.76%   -0.33%     
===========================================
  Files          126      126              
  Lines        11965    11969       +4     
===========================================
- Hits         10659    10624      -35     
- Misses        1306     1345      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[garrettwrong]

Updating with the dynamic importing compromise suggested by Joakim(numpy).

The getattr wrapper is now dynamically performing the importlib I was doing before at the top level.

This keeps the ability to do the following:

import aspire
s = aspire.source.Simulation()

[garrettwrong]

@j-c-c Can you do a prelim review on this? I'm still running the tests regarding the resource usage, but I think we want this either way at this point. (I know its already improving some resource usage cases and has the best compromise regarding imports).

[j-c-c]

This looks good to me. Everything seems to work as expected.

The only thing I would change (which is not functionally important) is adding backticks around {__name__} and {attr} in the error message.

[garrettwrong]

This looks good to me. Everything seems to work as expected.

The only thing I would change (which is not functionally important) is adding backticks around {__name__} and {attr} in the error message.

Sure, done.

[garrettwrong]

Merging.