Fix incorrect basis in Coef wrapper #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1067 +/- ##
========================================
Coverage 89.08% 89.08%
========================================
Files 126 126
Lines 11965 11965
========================================
Hits 10659 10659
Misses 1306 1306 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line in the FSPCA was using the incorrect basis. The small unit tests did not have enough coef to trigger the bug (larger take too long...). Found in timing testing.
There are two basis in play here. The pca "compressed" FSPCA and the some other steerable basis (givin during init). The evaluate should be converting from the compressed FSPCA and returning the steerable.
The bug here was returning the
comporessed basis.