Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Dec 15, 2023

Drafting release notes below. Still need to run the integration tests.


ASPIRE v0.12.1 is bugfix release, adding a mix of new features and cleanup.

This release provides the following features:

  • Interoperable 2D basis (covar2d, class averaging)
  • Improved Relion interoperability
  • Common Line SDP method
  • Shared 2D Basis tests
  • Common Lines optional fuzzy mask
  • Add Coef class
  • Nearest rotation (SVD) util method
  • FRC and FSC plotting option (disable cutoff)

Bug fixes:

  • Enforce grid conventions
  • FLE expand unit test convergence
  • Sync voting unit test patch
  • Whitening extremal value patch
  • Adds improved image projection tests
  • Adds improved volume rotation tests
  • FBBasis3D NaN values for large resolution
  • {F}PSWF basis float32 patch
  • Extend eval_coords to many volumes
  • Enforce block dtypes on assignment
  • Reduce package import resource util

Systems/CI Updates:

  • Flake8 Style Updates
  • Add public Issue template
  • Docstring cleanup
  • Adds docstring linting util to CI
  • Additional pytest conversions
  • Removes parameterized_class
  • Workaround Ray/pydantic dependency conflict

Documentation:

  • Adds Relion interoperability gallery
  • Adds Weighted spectral volume gallery
  • Update public facing Code of Conduct
  • Add K2 camera note to CTF estimator module
  • Removes deprecated legacy example scripts

@garrettwrong garrettwrong added documentation Improvements or additions to documentation CI Continuous Integration labels Dec 15, 2023
@garrettwrong garrettwrong requested a review from j-c-c December 15, 2023 19:49
@garrettwrong garrettwrong self-assigned this Dec 15, 2023
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@garrettwrong garrettwrong marked this pull request as ready for review December 15, 2023 21:01
@garrettwrong garrettwrong requested a review from janden as a code owner December 15, 2023 21:01
@codecov
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (dcedb21) 88.93% compared to head (8f94a24) 88.76%.

Files Patch % Lines
src/aspire/covariance/covar2d.py 93.03% 14 Missing ⚠️
src/aspire/downloader/data_fetcher.py 0.00% 12 Missing ⚠️
src/aspire/basis/steerable.py 93.70% 8 Missing ⚠️
src/aspire/basis/fspca.py 82.35% 6 Missing ⚠️
src/aspire/basis/basis.py 97.45% 3 Missing ⚠️
src/aspire/basis/fle_2d.py 95.89% 3 Missing ⚠️
src/aspire/basis/basis_utils.py 66.66% 2 Missing ⚠️
src/aspire/classification/rir_class2d.py 88.23% 2 Missing ⚠️
src/aspire/commands/denoise.py 0.00% 2 Missing ⚠️
src/aspire/__init__.py 85.71% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   88.93%   88.76%   -0.18%     
==========================================
  Files         127      126       -1     
  Lines       11471    11969     +498     
==========================================
+ Hits        10202    10624     +422     
- Misses       1269     1345      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettwrong
Copy link
Collaborator Author

Integration tests look similar to last release. Testing 10073 with higher reolutions to get an idea what FSC resolution it is achieving as a baseline.

Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Except the release notes should say “bugfix release”, not “minor release”.

@garrettwrong
Copy link
Collaborator Author

Looks good. Except the release notes should say “bugfix release”, not “minor release”.

RIght, fixed. Thanks.

@garrettwrong garrettwrong merged commit c227cd4 into main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants