Incremental Mean Volume Checkpoint #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1071 +/- ##
===========================================
+ Coverage 88.76% 88.80% +0.03%
===========================================
Files 126 126
Lines 11969 12001 +32
===========================================
+ Hits 10624 10657 +33
+ Misses 1345 1344 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
@j-c-c , since I added a bunch of doc string stuff probably best to start working through the review. Thanks |
Collaborator
Sounds good. I'll start taking a look today. |
j-c-c
requested changes
Jan 29, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good. Just a couple things.
janden
requested changes
Feb 6, 2024
Collaborator
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Looks great! Just a few things.
janden
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1070 by adding incremental checkpoint and max iteration limits.
Altered proposed solution in issue slightly. Once I got in the code I noticed it is more effective to return and restore coef directly than convert to/from Volume.
Still considering options for testing this.