-
Notifications
You must be signed in to change notification settings - Fork 26
Symmetry Boosting #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Symmetry Boosting #1072
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
36a3dbc
Initial boosting implementation.
j-c-c 0a0b86c
Add boosting flag
j-c-c 5f1d159
Boost the kernel.
j-c-c 27c98cb
Add IdentityFilter for Simulation. Fixes issue 978.
j-c-c 9059bc8
Adjust weights in MeanEstimator.
j-c-c 93907a9
Add testing for boosted MeanEstimator.
j-c-c 8ff66f0
Add to backproject docstring.
j-c-c 4bdd0eb
SymmetryGroup Check in backproject. With test.
j-c-c 19e139f
revert Simulation unique_filters.
j-c-c f94aec7
Temp fix for evaluate_src_filters_on_grid.
j-c-c 15801e1
accept symmetry_group strings in backproject.
j-c-c 6f54f61
Add mse test. Add docstring param.
j-c-c 4f915fe
refactor mse
j-c-c fdd1462
backproject return vol with symmetry group.
j-c-c 78c8d8d
Use tile instead of concatenate.
j-c-c 27a3608
Add boost flag test.
j-c-c a5c50b8
Add WeightedVolumesEstimator boosting test.
j-c-c cbad44d
Apply backproject boosting in loop.
j-c-c 2a7d9a7
Fix manually boosted rots in test_boost_flag.
j-c-c 93e64fb
Boost in loop in compute_kernel.
j-c-c 865c4d7
remove IdentityFilter in boosting test.
j-c-c c4a8c35
remove import.
j-c-c fadf481
reword docstring
j-c-c 7835347
Add testing docstring
j-c-c 3878cc5
Add missing docstring.
j-c-c 9695418
remove unnecesary wildcard
j-c-c 6a70ee0
Cache testing source.
j-c-c 9f421fe
Use count instead of confusing math
j-c-c 3a7e103
typo
j-c-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why apply
1/sym_orderhere instead of inbackproject?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason other than it made sense to me at the time. This is where we are scaling by number of images and boosting increases the number of images. It also pairs nicely with scaling on line 187.