Skip to content

CUDA 12 Support #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2024
Merged

CUDA 12 Support #1074

merged 1 commit into from
Jan 17, 2024

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Jan 12, 2024

Adds gpu_12x extension and updates GHA CI to use.

@garrettwrong garrettwrong added enhancement New feature or request CI Continuous Integration extern Relating to external changes dependencies Pull requests that update a dependency file labels Jan 12, 2024
@garrettwrong garrettwrong self-assigned this Jan 12, 2024
@codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e81cbbf) 88.76% compared to head (1577a5b) 88.76%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1074   +/-   ##
========================================
  Coverage    88.76%   88.76%           
========================================
  Files          126      126           
  Lines        11969    11969           
========================================
  Hits         10624    10624           
  Misses        1345     1345

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettwrong garrettwrong requested a review from j-c-c January 17, 2024 16:17
@garrettwrong garrettwrong marked this pull request as ready for review January 17, 2024 16:17
@garrettwrong garrettwrong requested a review from janden as a code owner January 17, 2024 16:17
j-c-c
j-c-c approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jan 17, 2024

Merging. Will finish bringing up decaf using this current env.

@garrettwrong garrettwrong merged commit 498679e into develop Jan 17, 2024
@garrettwrong garrettwrong deleted the cuda122 branch January 17, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

CI Continuous Integration dependencies Pull requests that update a dependency file enhancement New feature or request extern Relating to external changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c