Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

I'm not sure pip will pickup the latest win package without a new release, but giving it a try...

This is based off #1077 to get past the check phase.

@garrettwrong garrettwrong added bug Something isn't working cleanup extern Relating to external changes dependencies Pull requests that update a dependency file labels Jan 26, 2024
@garrettwrong garrettwrong self-assigned this Jan 26, 2024
@garrettwrong garrettwrong requested a review from janden as a code owner January 26, 2024 12:22
@codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (498679e) 88.76% compared to head (572ac02) 88.76%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1078   +/-   ##
========================================
  Coverage    88.76%   88.76%           
========================================
  Files          126      126           
  Lines        11969    11969           
========================================
  Hits         10624    10624           
  Misses        1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettwrong
Copy link
Collaborator Author

Looks like we will need to wait for the next finufft release to naturally install the fixed packages. Closing.

@garrettwrong garrettwrong deleted the retry_finwin_pkg branch November 20, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cleanup dependencies Pull requests that update a dependency file extern Relating to external changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants