Allow RelionSource to be double precision #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1079 +/- ##
========================================
Coverage 88.82% 88.82%
========================================
Files 126 126
Lines 12024 12028 +4
========================================
+ Hits 10680 10684 +4
Misses 1344 1344 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Closes #871 . |
Collaborator
Author
|
The 380px reconstruction of 10073 just completed successfully with doubles using a similar branch. I will setup to retest with the exact code in this PR. (Experiment was started before the code/PR were made). |
Collaborator
Author
|
Full resolution mean estimation of 10073 was successful using the published (Relion) shifts and rotations in combination with the doubles patch in this PR. Opening it up for consideration. 
|
j-c-c
requested changes
Feb 2, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Looks good! It's nice it only took a couple lines. Just one question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MeanEstimationfails to converge at higher resolutions for experimental data (189 and higher) in single precision. I believe this is probably related to the accuracy of the basis in these conditions, but there is more work to be done there at another time.This small PR allows
RelionSourceto upcast images and supporting data as doubles to be consumed by other components. It adds some tests checking the dtype override occurs.This resolved for 189 pixel reconstructions and is currently being tested at 380. Will update, WIP draft for now.