-
Notifications
You must be signed in to change notification settings - Fork 26
Doc updates 24q1 #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates 24q1 #1082
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1082 +/- ##
========================================
Coverage 88.82% 88.82%
========================================
Files 126 126
Lines 12031 12031
========================================
Hits 10687 10687
Misses 1344 1344 ☔ View full report in Codecov by Sentry. |
aee31fb to
fd0fd3d
Compare
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one addition.
| # |CoordinateSource| whiten | | CLSymmetryCn | | | ||
| # +----------------+--------------------+-----------------+----------------+---------------------+ | ||
| # | | phase_flip | | | | | ||
| # | | phase_flip | | CommonlineSDP | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add CLSymmetryC2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I forgot about that one. Haven't tried it yet :).
Added
|
@j-c-c , while I was in there adding C2, I made some small changes to some |
15c9663 to
3776674
Compare
3776674 to
4fee141
Compare
j-c-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Plots look nice!
janden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Resolves #1080 . These are the entries noted in the issue. WIP, still plan to review gallery for other updates...