Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Resolves #1080 . These are the entries noted in the issue. WIP, still plan to review gallery for other updates...

@garrettwrong garrettwrong added documentation Improvements or additions to documentation cleanup labels Feb 7, 2024
@garrettwrong garrettwrong self-assigned this Feb 7, 2024
@codecov
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a900ab) 88.82% compared to head (68874c9) 88.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1082   +/-   ##
========================================
  Coverage    88.82%   88.82%           
========================================
  Files          126      126           
  Lines        12031    12031           
========================================
  Hits         10687    10687           
  Misses        1344     1344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one addition.

# |CoordinateSource| whiten | | CLSymmetryCn | |
# +----------------+--------------------+-----------------+----------------+---------------------+
# | | phase_flip | | | |
# | | phase_flip | | CommonlineSDP | |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add CLSymmetryC2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I forgot about that one. Haven't tried it yet :).

Added

@garrettwrong
Copy link
Collaborator Author

@j-c-c , while I was in there adding C2, I made some small changes to some show calls also. I think they look a little better now, but lmk, thanks!

Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Plots look nice!

@garrettwrong garrettwrong marked this pull request as ready for review February 15, 2024 16:45
@garrettwrong garrettwrong requested a review from janden as a code owner February 15, 2024 16:45
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@garrettwrong garrettwrong enabled auto-merge (rebase) February 16, 2024 15:18
@garrettwrong garrettwrong merged commit 68768fe into develop Feb 16, 2024
@garrettwrong garrettwrong deleted the doc_updates_24q1 branch February 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants