Default Estimator 3D basis #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
force-pushed
the
default_est_basis
branch
from
a5252c3 to
9341e0b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1085 +/- ##
========================================
Coverage 88.82% 88.82%
========================================
Files 126 126
Lines 12028 12031 +3
========================================
+ Hits 10684 10687 +3
Misses 1344 1344 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to manually prescribe FFBBasis3D clutters up a lot of our examples. This PR just instantiates the default (
FFBBasis3D) for our code based on theImageSourcein our volume estimation classes. This removes the clutter from the user and examples side.Unfortunately adds the clutter back to the legacy tests, but they will probably be updated at some point anyway for other reasons.