cufinufft v2.2.0 migration #1087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our
pyproject.tomltowards CUDA 12 with cufinufft v2.2.0.For cufinufft v2.2.0, the changes described in the python migration guide were applied.
I was expecting this release to solve the float/double bug originally reported in the legacy cufinufft repo, but it seems like that bug (or one with the same symptoms) is still there in the pypi package. I will look into this just a little and potentially create a bug report in the main finufft repo.
I'm not sure why this seg faulted in the CI. I ran into this locally, but it went away after some (system) package changes. Perhaps I need to restart the runner service. Will look into that.