Skip to content

Gemmi Update #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2024
Merged

Gemmi Update #1089

merged 2 commits into from
Feb 22, 2024

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Feb 20, 2024

Resolves #1088

@j-c-c j-c-c added bug Something isn't working CI Continuous Integration extern Relating to external changes labels Feb 20, 2024
@j-c-c j-c-c self-assigned this Feb 20, 2024
@codecov
Copy link

codecov bot commented Feb 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68768fe) 88.82% compared to head (8f805f8) 88.82%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1089   +/-   ##
========================================
  Coverage    88.82%   88.82%           
========================================
  Files          126      126           
  Lines        12031    12031           
========================================
  Hits         10687    10687           
  Misses        1344     1344

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-c-c j-c-c requested a review from garrettwrong February 20, 2024 15:08
garrettwrong
garrettwrong approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j-c-c j-c-c marked this pull request as ready for review February 20, 2024 15:26
@j-c-c j-c-c requested a review from janden as a code owner February 20, 2024 15:26
@j-c-c
Copy link
Collaborator Author

j-c-c commented Feb 20, 2024

Looks like we're getting a segfault on macOS-11. I've submitted a bug report to gemmi.

@garrettwrong
Copy link
Collaborator

garrettwrong commented Feb 22, 2024

Going to merge this in. I think we will do a quick patch release so that our main branch and pypi packages are coherent with the available gemmi packages.

@garrettwrong garrettwrong merged commit 8fc47d6 into develop Feb 22, 2024
@j-c-c j-c-c mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettwrong garrettwrong garrettwrong approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@j-c-c j-c-c

Labels

bug Something isn't working CI Continuous Integration extern Relating to external changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-c-c @garrettwrong