Skip to content

Use _cached_im when available in IndexedSource #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2024
Merged

Use _cached_im when available in IndexedSource #1100

merged 4 commits into from
Mar 5, 2024

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Mar 1, 2024

Tentative changes for caching internal to IndexedSource. WIP

@garrettwrong garrettwrong self-assigned this Mar 1, 2024
@garrettwrong garrettwrong added bug Something isn't working cleanup labels Mar 1, 2024
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Mar 1, 2024

Closes #1098

@garrettwrong garrettwrong requested a review from j-c-c March 4, 2024 15:19
j-c-c
j-c-c approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong marked this pull request as ready for review March 5, 2024 15:15
@garrettwrong garrettwrong requested a review from janden as a code owner March 5, 2024 15:15
janden
janden approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@janden janden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good… Thanks!

@garrettwrong garrettwrong merged commit e0979c5 into develop Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@j-c-c j-c-c j-c-c approved these changes

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garrettwrong @janden @j-c-c