FFT swap #1104
Merged
FFT swap #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettwrong
added
CI
Collaborator
Author
The good news is that Bad news is that a depend ( |
Numpy Was previously bound <2 by pyfftw deps.
janden
approved these changes
Jun 17, 2024
Collaborator
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Looks good. Just one question really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure we will proceed down this path, but I've put together a draft of swapping out PyFFTW in favor of the scipy FFT.
I still need to check the status of
finuffton Apple M1 machines before considering this further (possibly tomorrow).