Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Testing this locally now on a few experiments. Gives me a better estimate of how long this step will take.

2024-03-15 11:38:03,223 INFO [aspire.source.image] Attempting to create an Image object from Numpy array.
2024-03-15 11:38:03,224 INFO [aspire.source.image] Creating ArrayImageSource with 3000 images.
2024-03-15 11:38:03,225 INFO [aspire.source.image] Creating OrientedSource with 3000 images.
2024-03-15 11:38:03,225 INFO [aspire.reconstruction.estimator] {self.__class__.__name__} instantiating default basis.
2024-03-15 11:38:03,225 INFO [aspire.basis.ffb_3d] Expanding 3D map in a frequency-domain Fourier–Bessel basis using the fast method.
2024-03-15 11:38:31,230 INFO [aspire.source.image] Estimating rotations for <aspire.source.image.ArrayImageSource object at 0x7fc70d2d3160> using <aspire.abinitio.commonline_sync.CLSyncVoting object at 0x7fc61d8665b0>.
2024-03-15 11:38:31,638 INFO [aspire.operators.polar_ft] Represent 2D image in a polar Fourier grid
Searching over common line pairs:   1%|          | 39088/4498500 [03:06<5:52:55, 210.59it/s]

I see one of my log messages has a bug, I'll fix that too while I'm in here.

@garrettwrong garrettwrong added enhancement New feature or request good first issue Good for newcomers cleanup labels Mar 15, 2024
@garrettwrong garrettwrong self-assigned this Mar 15, 2024
@garrettwrong garrettwrong requested a review from j-c-c March 15, 2024 15:43
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing.

@garrettwrong garrettwrong requested a review from j-c-c March 20, 2024 13:27
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettwrong garrettwrong marked this pull request as ready for review March 20, 2024 13:32
@garrettwrong garrettwrong requested a review from janden as a code owner March 20, 2024 13:32
@garrettwrong
Copy link
Collaborator Author

Low risk, plan to merge after CI runs.

@garrettwrong garrettwrong merged commit 77d4f0d into develop Mar 20, 2024
@garrettwrong garrettwrong deleted the cl_pbar branch March 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants