Skip to content

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Apr 26, 2024

CI was failing on our self hosted runner due to some changes in how pytest is bound into path: https://github.com/ComputationalCryoEM/ASPIRE-Python/actions/runs/8838267362/job/24269024633#step:5:11

Letting python handle the paths (ie. use python -m pytest to invoke pytest) fixes the problem.

@j-c-c j-c-c added bug Something isn't working CI Continuous Integration labels Apr 26, 2024
@j-c-c j-c-c self-assigned this Apr 26, 2024
garrettwrong
garrettwrong previously approved these changes Apr 26, 2024
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@j-c-c j-c-c marked this pull request as ready for review April 26, 2024 15:36
@j-c-c j-c-c requested a review from janden as a code owner April 26, 2024 15:36
@j-c-c
Copy link
Collaborator Author

j-c-c commented Apr 26, 2024

Looks like more CI problems: https://github.com/ComputationalCryoEM/ASPIRE-Python/actions/runs/8850744004/job/24305751406?pr=1112#step:3:1

Added the suggested fix.

@garrettwrong
Copy link
Collaborator

Success 🚀

@j-c-c j-c-c merged commit e23d9b1 into develop Apr 26, 2024
@j-c-c j-c-c deleted the ampere_ci branch April 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI Continuous Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants