Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Closes #1121

conda-incubator/setup-miniconda@v3 is using Node 20. Should resolve (Node 16) deprecation message.

Because this only occurs on the Conda CI, I'm just going to kick off the full pull request now instead of our usual two step process.

@garrettwrong garrettwrong added cleanup extern Relating to external changes dependencies Pull requests that update a dependency file labels Jun 3, 2024
@garrettwrong garrettwrong self-assigned this Jun 3, 2024
@garrettwrong garrettwrong requested a review from janden as a code owner June 3, 2024 12:39
@garrettwrong
Copy link
Collaborator Author

Bummer, looks like this breaks other things. Looking

@garrettwrong garrettwrong changed the title update GHA miniconda setup version to v3 update GHA miniconda setup version to ~v3~ v2.3.0 Jun 3, 2024
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jun 3, 2024

v3 appears to have other conflicts at this time. 2.3.0, the final tag in the v2 series, appears to be working well for us. Will let the CI run and tag for review on success.

@garrettwrong garrettwrong requested a review from j-c-c June 3, 2024 14:35
@garrettwrong
Copy link
Collaborator Author

Thanks. Going to push this through.

@garrettwrong garrettwrong merged commit cf081e1 into develop Jun 3, 2024
@garrettwrong garrettwrong deleted the minicon branch June 3, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup dependencies Pull requests that update a dependency file extern Relating to external changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants