Skip to content

Move arrays to build #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2024
Merged

Move arrays to build #1128

merged 5 commits into from
Jun 13, 2024

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Jun 13, 2024 •
edited
Loading

This moves some array creation into build for ffb2d and fixes the excessive cupy.fill kernel launches

@j-c-c j-c-c self-assigned this Jun 13, 2024
@j-c-c j-c-c requested a review from garrettwrong June 13, 2024 16:20
garrettwrong
garrettwrong approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

@j-c-c j-c-c marked this pull request as ready for review June 13, 2024 18:16
@j-c-c j-c-c requested a review from janden as a code owner June 13, 2024 18:16
@j-c-c j-c-c merged commit 6241c22 into hack24 Jun 13, 2024
@garrettwrong garrettwrong deleted the hack24_ffb_build branch June 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettwrong garrettwrong garrettwrong approved these changes

@janden janden Awaiting requested review from janden

Assignees

@j-c-c j-c-c

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-c-c @garrettwrong