Skip to content

support np1 and np2 ComplexWarning #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2024
Merged

support np1 and np2 ComplexWarning #1134

merged 1 commit into from
Jun 17, 2024

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Jun 17, 2024

Closes #1133

@garrettwrong garrettwrong self-assigned this Jun 17, 2024
@garrettwrong garrettwrong requested a review from j-c-c June 17, 2024 13:22
@garrettwrong garrettwrong added CI Continuous Integration extern Relating to external changes dependencies Pull requests that update a dependency file labels Jun 17, 2024
j-c-c
j-c-c approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@garrettwrong garrettwrong marked this pull request as ready for review June 17, 2024 13:34
@garrettwrong garrettwrong requested a review from janden as a code owner June 17, 2024 13:34
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jun 17, 2024

Merging 🚀

@garrettwrong garrettwrong merged commit 2d834ff into develop Jun 17, 2024
@garrettwrong garrettwrong deleted the np2 branch June 17, 2024 16:01
@garrettwrong garrettwrong mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

CI Continuous Integration dependencies Pull requests that update a dependency file extern Relating to external changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c