Skip to content

More 10081 fixes #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2024
Merged

More 10081 fixes #1149

merged 7 commits into from
Jul 12, 2024

Conversation

@garrettwrong
Copy link
Collaborator

@garrettwrong garrettwrong commented Jul 2, 2024

Some changes required to allow the 10081 experiment to run to completion and use the recently added symmetry feature.

@garrettwrong garrettwrong added bug Something isn't working documentation Improvements or additions to documentation cleanup labels Jul 2, 2024
@garrettwrong garrettwrong self-assigned this Jul 2, 2024
@garrettwrong garrettwrong requested a review from j-c-c July 3, 2024 14:30
@j-c-c j-c-c mentioned this pull request Jul 8, 2024
Merged
j-c-c
j-c-c reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we weren't actually passing the symmetry groups into ClassAvgSources. I added the necessary changes in #1151. If you're good with those changes I can merge them into this branch.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jul 10, 2024

Added a diagnostic log message.

@garrettwrong garrettwrong requested a review from j-c-c July 11, 2024 14:00
j-c-c
j-c-c previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@j-c-c j-c-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@garrettwrong garrettwrong marked this pull request as ready for review July 11, 2024 14:34
@garrettwrong garrettwrong requested a review from janden as a code owner July 11, 2024 14:34
@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jul 11, 2024 •
edited
Loading

I'll kick off re-running this I've started this run and will ensure the log message fires before merging into develop.

@garrettwrong
Copy link
Collaborator Author

garrettwrong commented Jul 12, 2024

Reconstruction completed. Boosting message fired, good, but it was not formatted. Just added the missing 'f'. Will merge after the CI completes.

@garrettwrong garrettwrong merged commit 2b63e39 into develop Jul 12, 2024
@garrettwrong garrettwrong deleted the more_10081_fixes branch July 12, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-c-c j-c-c j-c-c left review comments

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

@garrettwrong garrettwrong

Labels

bug Something isn't working cleanup documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettwrong @j-c-c