Class Image line projection method #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-c-c
requested changes
Jul 8, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
This looks great! Here's some initial things from my first pass through this.
j-c-c
reviewed
Jul 8, 2024
garrettwrong
force-pushed
the
lineproject
branch
from
6be46d6 to
40a94b8
Compare
Collaborator
|
@certifiedp , how are the changes coming? Thanks |
marc to continue
Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
Co-authored-by: Marc Karimi <mk3652@decaf.math.princeton.edu.private>
…ly, renamed variables
garrettwrong
force-pushed
the
lineproject
branch
from
b40f182 to
a8adc05
Compare
Collaborator
|
Rebased with latest develop. |
Collaborator
|
@j-c-c can you take a quick look at this for us? If it looks good I'll ready for final reviews. Thanks. |
j-c-c
requested changes
Jul 18, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Just two very small things. Otherwise looks great!
j-c-c
previously approved these changes
Jul 18, 2024
Collaborator
j-c-c
left a comment
j-c-c
left a comment
There was a problem hiding this comment.
Approving. You guys can make a decision on the one change I requested.
garrettwrong
approved these changes
Jul 19, 2024
Collaborator
garrettwrong
left a comment
garrettwrong
left a comment
There was a problem hiding this comment.
Cool, I'll open it up for final review, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
image.projectto the Image class and a unit test comparing to Scikit image radon.